[Sema] Permit dot reference with isolation change without call #79575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamCmiel
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please test |
AdamCmiel
force-pushed
the
curried_thunk_actor_isolation
branch
2 times, most recently
from
171a0c9 to
51941e9
Compare
|
@swift-ci Please test |
|
@swift-ci Please test |
|
@NuriAmari this is actually already fixed on main. https://godbolt.org/z/GjsdWv8bx. |
|
This is now something that is the province of region isolation. I am not sure if we actually need to muck with Sema. That being said, it would be great to transition this PR to just be for adding tests. More tests are always good. |
|
I'll update |
AdamCmiel
force-pushed
the
curried_thunk_actor_isolation
branch
from
78b7d5c to
03321b6
Compare
A dot-reference of a method defined on `Self` (as well as through `self`) should be permitted to be made in a different actor isolation than the referenced function's actor isolation if a call is not yet made, as the DeclRefExpr can store the isolation of the referenced decl. That said, we currently can only express that known isolation with global actor annotations until the language adopts closure isolation control. This is fixed on main so just recomming for the tests
AdamCmiel
force-pushed
the
curried_thunk_actor_isolation
branch
from
03321b6 to
939aaa9
Compare
|
Updated to just include the tests. @gottesmm, better this? |
|
@swift-ci please test |
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dot-reference of a method defined on
Self(as well as throughself) should be permitted to be made in a different actor isolation than the referenced function's actor isolation if a call is not yet made, as the DeclRefExpr can store the isolation of the referenced decl. That said, we currently can only express that known isolation with global actor annotations until the language adopts closure isolation control.Resolves (for global actors) #76453