Skip to content

[swift-inspect] On Darwin, don't try to inspect processes that don't have Swift. #79582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Feb 24, 2025

When we locate libswiftCore.dylib in the remote process, check for failure and give up immediately if we don't find one. If the process doesn't have Swift, there's no point in trying to inspect anything in it.

rdar://143978694

…have Swift.

When we locate libswiftCore.dylib in the remote process, check for failure and give up immediately if we don't find one. If the process doesn't have Swift, there's no point in trying to inspect anything in it.

rdar://143978694
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is a better message we could emit, but this can be something that we improve later.

@mikeash
Copy link
Contributor Author

mikeash commented Feb 24, 2025

@swift-ci please smoke test

@mikeash mikeash enabled auto-merge February 24, 2025 20:02
@mikeash mikeash merged commit 068fd14 into swiftlang:main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants