[🍒] [6.1] Discard non-indexed relations instead of entire references. #79589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dylansturg
commented
Feb 24, 2025
dylansturg
commented
- Explanation:
- Fixes a regression in index data, where entire references are discarded instead of just the relation. This occurs when the reference has a relation where the related entity is not indexed. Instead of discarding the entire reference, e.g. a function call, this fix discards the relation to a non-indexed symbol, e.g. the received-by relation to a private type.
- Scope:
- This adds references to the index output, and should not impact code compilation or other compiler outputs. These references were emitted in the past, removed starting in Swift 6.0, so reintroducing them is likely safe.
- Issues:
- N/A
- Original PRs:
- Discard non-indexed relations instead of entire references. #79577
- Risk:
- Low. This only adds some new references to index data.
- Testing:
- New test case, and existing test suite for index data and its users.
- Reviewers:
- @bnbarham
- @ahoppen
References for function calls where there would normally be a received-by relationship were being discarded. This happened when the receiver type is a non-indexed type, e.g. a private type in a system framework. The function call could be public or defined in any module though, so discarding it entirely because of the receiver type is not desirable. Follow up to refine the behavior of [previous commit](swiftlang@b65d8c2).
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
bnbarham
approved these changes
Feb 25, 2025
|
@swift-ci please test macOS platform |
1 similar comment
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.