[6.1][Runtime] Add ccAttrs to slow path in compatibility overrides #79595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drexin
commented
Feb 25, 2025
drexin
commented
- Explanation: The ccArgs were accidentally dropped when introducing the slow path, which causes CC mismatches for functions using custom CC.
- Scope: Compatibility Overrides
- Issues: rdar://145523626
- Original PRs: [Runtime] Add ccAttrs to slow path in compatibility overrides #79594
- Risk: Low. The change only matches the CC between fast and slow path.
- Testing: Examined the resulting asm to ensure the correct behavior.
- Reviewers: @mikeash
rdar://145523626 This was accidentally dropped when introducing the slow path, which causes CC mismatches for functions using custom CC.
|
@swift-ci test |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.