AST: Centralize AvailabilityDomain lookup #79626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous algorithm failed to correctly handle the cases where some grouped `@available` attributes could be marked invalid prior to type checking attributes.
tshortli
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
tshortli
force-pushed
the
availability-domain-lookup
branch
from
ea8a9f4 to
ece70eb
Compare
Implement lookup of availability domains for identifiers on `AvailabilityDomainOrIdentifier`. Add a bit to that type which represents whether or not lookup has already been attempted. This allows both `AvailableAttr` and `AvailabilitySpec` to share a common implementation of domain lookup.
tshortli
force-pushed
the
availability-domain-lookup
branch
from
ece70eb to
62c8e72
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement lookup of availability domains for identifiers on
AvailabilityDomainOrIdentifier. Add a bit to that type which represents whether or not lookup has already been attempted. This allows bothAvailableAttrandAvailabilitySpecto share a common implementation of domain lookup.Also, fix a bug in the diagnostics for missing wildcards in
@availableattributes.