AST: Fix TypeBase::hasSimpleTypeRepr() for ProtocolCompositionType #79647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the introduction of noncopyable generics, a ProtocolCompositionType was 'simple' if it was exactly 'Any' or 'AnyObject'. Now, there is a new simple case, where we have a single inverse requirement '~Copyable' or '~Escapable', and the old logic was never updated to account for this possibility. Instead, it would ignore inverses, so it would claim that a composition like `P & ~Copyable` was simple when it shouldn't be. Fixes rdar://139465298.
|
@swift-ci Please smoke test |
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Feb 27, 2025
With Slava’s fix in swiftlang#79647, we can now refer to generalized type existentials in ABI stable code.
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Feb 28, 2025
With Slava’s fix in swiftlang#79647, we can now refer to generalized type existentials in ABI stable code.
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Mar 14, 2025
With Slava’s fix in swiftlang#79647, we can now refer to generalized type existentials in ABI stable code.
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Mar 18, 2025
With Slava’s fix in swiftlang#79647, we can now refer to generalized type existentials in ABI stable code.
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Mar 21, 2025
With Slava’s fix in swiftlang#79647, we can now refer to generalized type existentials in ABI stable code.
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Mar 26, 2025
With Slava’s fix in swiftlang#79647, we can now refer to generalized type existentials in ABI stable code.
lorentey
added a commit
to lorentey/swift
that referenced
this pull request
Mar 26, 2025
With Slava’s fix in swiftlang#79647, we can now refer to generalized type existentials in ABI stable code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the introduction of noncopyable generics, a ProtocolCompositionType was 'simple' if it was exactly 'Any' or 'AnyObject'. Now, there is a new simple case, where we have a single inverse requirement '~Copyable' or '~Escapable', and the old logic was never updated to account for this possibility. Instead, it would ignore inverses, so it would claim that a composition like
P & ~Copyablewas simple when it shouldn't be.Fixes rdar://139465298.