[cxx-interop] Interpret Self as a static shorthand for FRTs #79662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
j-hui,
fahadnayyar,
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
egorzhdan
reviewed
Feb 27, 2025
Xazax-hun
force-pushed
the
gaborh/dynamic-self-frt
branch
2 times, most recently
from
905ebdf to
15731c3
Compare
j-hui
approved these changes
Mar 4, 2025
Xazax-hun
force-pushed
the
gaborh/dynamic-self-frt
branch
from
716ae55 to
3a287c1
Compare
We do not have dynamic self metadata for foreign reference types. rdar://145066864
Co-authored-by: Anthony Latsis <[email protected]>
Xazax-hun
force-pushed
the
gaborh/dynamic-self-frt
branch
from
3a287c1 to
ebfde99
Compare
Co-authored-by: John Hui <[email protected]>
Xazax-hun
force-pushed
the
gaborh/dynamic-self-frt
branch
from
ebfde99 to
8f58ad6
Compare
|
@swift-ci please smoke test |
It looks like the root cause of the problem is that we do not support emitting metadata for some foreign types on Windows. This is a known limitation and the crash is not related to my patch, the code crashes the compiler even before my changes on Windows. Disabling the test on Windows for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not have dynamic self metadata for foreign reference types.
rdar://145066864