[Dependency Scanning] Refine cross-import overlay detection algorithm #79676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atement is '@_exported'
artemcm
requested review from
xymus,
cachemeifyoucan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
artemcm
force-pushed
the
RefineCrossImportOverlayResolutionLogic
branch
from
4a2521f to
26c8f2f
Compare
artemcm
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui and
fahadnayyar
as code owners
artemcm
force-pushed
the
RefineCrossImportOverlayResolutionLogic
branch
from
26c8f2f to
886f8c8
Compare
|
@swift-ci test |
xymus
reviewed
Feb 27, 2025
| @@ -60,6 +60,8 @@ using IsStaticField = BCFixed<1>; | |||
| using IsForceLoadField = BCFixed<1>; | |||
| /// A bit taht indicates whether or not an import statement is optional | |||
| using IsOptionalImport = BCFixed<1>; | |||
| /// A bit taht indicates whether or not an import statement is @_exported | |||
There was a problem hiding this comment.
There's a repeated typo on taht with the lines above.
xymus
approved these changes
Feb 27, 2025
The algorithm already performs pairwise checks on module dependencies brought into compilation per-source-file. Previously, the algorithm considered the entire sub-graph of a given source file. Actual source compiles do not consider the full transitive module dependency set for cross-import-overlay lookup, but rather only directly-imported modules in a given source file, and '@_exported import' Swift transitive dependencies. This change adds tracking of whether a given import statement is 'exported' to the dependency scanner and then refines the cross-import overlay lookup logic to only consider transitive modules that are exported by directly-imported dependencies.
artemcm
force-pushed
the
RefineCrossImportOverlayResolutionLogic
branch
from
886f8c8 to
0555764
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm already performs pairwise checks on module dependencies brought into compilation per-source-file. Previously, the algorithm considered the entire sub-graph of a given source file. Actual source compiles do not consider the full transitive module dependency set for cross-import-overlay lookup, but rather only directly-imported modules in a given source file, and '@_exported import' Swift transitive dependencies.
This change adds tracking of whether a given import statement is 'exported' to the dependency scanner and then refines the cross-import overlay lookup logic to only consider transitive modules that are exported by directly-imported dependencies.