CMake: Allow setting optimization remark type #79679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
shahmishal,
edymtt,
justice-adams-apple and
compnerd
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Feb 27, 2025
Optimization remarks were always emitted on Darwin but not on the other platforms and were forced to use the bitstream format. Adding a flag to enable or disable them as desired and specify the desired output format. Fixes: swiftlang#79279
etcwilde
force-pushed
the
ewilde/opt-remarks
branch
from
0f1188c to
f6edc3d
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization remarks were always emitted on Darwin but not on the other platforms and were forced to use the bitstream format. Adding a flag to enable or disable them as desired and specify the desired output format.
These had been hard-coded to
bitstreamfor all platforms the old build system, regardless of whether folks were using them.Fixes: #79279