Skip to content

[Clang importer] Infer @unsafe independent of strict safety checking mode #79680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

[Clang importer] Infer @unsafe independent of strict safety checking mode #79680

merged 1 commit into from
Feb 28, 2025

Conversation

DougGregor
Copy link
Member

No description provided.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor enabled auto-merge February 27, 2025 23:59
@DougGregor DougGregor merged commit bad5adb into swiftlang:main Feb 28, 2025
3 checks passed
@DougGregor
Copy link
Member Author

@Xazax-hun there's one remaining Feature::StrictMemorySafety check in the Clang importer that should be removed, but at the moment it triggers a circular reference, so it's going to take some more effort.

@DougGregor DougGregor deleted the clang-importer-always-unsafe branch February 28, 2025 05:22
@Xazax-hun
Copy link
Contributor

@DougGregor, got it! Just opened #79693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @Xazax-hun