[embedded][Concurrency] Fix missing swift_deletedAsyncMethodError #79706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
ktoso,
phausler,
al45tair,
rauhul,
zoecarver,
eeckstein and
dschaefer2
|
@swift-ci please test |
kubamracek
force-pushed
the
embedded-concurrency-deleted-method
branch
from
39bafce to
71a5e39
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attached testcase demonstrates the problem: If the optimizer eliminates an async method, the vtable pointer is replaced with a swift_deletedAsyncMethodError, and in Embedded Swift we ended up failing to link in such a situation because swift_deletedAsyncMethodError wasn't getting imported at the SIL level (there's no visible link to it at the SIL level). To fix that let's declare it in RuntimeFunctions.def, plus we need to adjust the GOT creating code to be able to handle the situation when the link entity is in the current module already.
rdar://145584159