Skip to content

[SE-0447] Span and RawSpan tests #79708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 8, 2025
Merged

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Feb 28, 2025

Ported the Span and RawSpan tests from the prototype package, as promised long ago.

Includes some gardening updates for Span and RawSpan

@glessard glessard requested a review from a team as a code owner February 28, 2025 22:02
@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@glessard
Copy link
Contributor Author

glessard commented Mar 6, 2025

@swift-ci please smoke test

@glessard
Copy link
Contributor Author

glessard commented Mar 6, 2025

@swift-ci please smoke test macOS platform

Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉 Hurray for tests! Everything looks great, just have a few notes inline.

We should add a .requires(.stdlib_6_2) operator to StdLibUnitTest so you don't have to have that custom skip repeated everywhere…

@glessard
Copy link
Contributor Author

glessard commented Mar 7, 2025

@swift-ci please test

@glessard glessard enabled auto-merge March 7, 2025 17:29
glessard and others added 5 commits March 7, 2025 13:23
These should be available for any type of element `Span` can have in the future, including non-escapable elements. Making this change now avoids future churn.

Addresses rdar://146130842
@glessard
Copy link
Contributor Author

glessard commented Mar 7, 2025

@swift-ci please test

@glessard glessard merged commit 7214717 into swiftlang:main Mar 8, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants