-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SE-0447] Span and RawSpan tests #79708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
- these were missed in a previous code change
- `RangeExpression` implicitly involves bounds checking, so this was misleading.
@swift-ci please smoke test |
@swift-ci please smoke test macOS platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉 Hurray for tests! Everything looks great, just have a few notes inline.
We should add a .requires(.stdlib_6_2)
operator to StdLibUnitTest so you don't have to have that custom skip repeated everywhere…
@swift-ci please test |
These should be available for any type of element `Span` can have in the future, including non-escapable elements. Making this change now avoids future churn. Addresses rdar://146130842
@swift-ci please test |
Ported the
Span
andRawSpan
tests from the prototype package, as promised long ago.Includes some gardening updates for
Span
andRawSpan