[Sema/SILGen] Import ObjC async functions as nonisolated(nonsending) by …
#79717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on some work we need to do for witnesses. |
xedin
force-pushed
the
objc-handlers-are-execution-caller
branch
from
48fb45e to
7320fea
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
changed the title
@execution(caller) by …nonisolated(nonsending) by …
xedin
force-pushed
the
objc-handlers-are-execution-caller
branch
from
26044d3 to
6a53bef
Compare
…` by default These functions already have special code generation that keeps them in the caller's isolation context, so there is no behavior change here. Resolves: rdar://145672343
…to native thunks. We do not actually hop since we know that
…ated parameters of a native function.
xedin
force-pushed
the
objc-handlers-are-execution-caller
branch
from
6a53bef to
87cee09
Compare
xedin
requested review from
jckarter,
ktoso,
hborla and
slavapestov
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…d `@objc` async handlers to be `@concurrent This is behavior pre-SE-0461 which is the safest option instead of inferring `nonisolated(nonsending)` and changing the calling convention and foregoing Sendable checking.
xedin
force-pushed
the
objc-handlers-are-execution-caller
branch
from
87cee09 to
c25d2fa
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…default
These functions already have special code generation that keeps them in the caller's isolation context, so there is no behavior change here.
Resolves: rdar://145672343