Skip to content

[concurrency] Add initial support for SwiftSettings to control defaultIsolation at the file level. #79727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Mar 1, 2025

We introduce a new macro called #SwiftSettings that can be used in conjunction with a new stdlib type called SwiftSetting to control the default isolation at the file level. It overrides the current default isolation whether it is the current nonisolated state or main actor (when -enable-experimental-feature UnspecifiedMeansMainActorIsolated is set).

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 1, 2025

@swift-ci test

@gottesmm gottesmm force-pushed the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch from 3ae339c to bc4e1b6 Compare March 3, 2025 21:34
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2025

Had to fix some feature set related stuff

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 3, 2025

@swift-ci smoke test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better with this spelling! <3

@gottesmm gottesmm force-pushed the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch 2 times, most recently from 6046fb1 to 762d518 Compare March 4, 2025 16:56
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 4, 2025

@swift-ci smoke test

@gottesmm gottesmm force-pushed the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch from 762d518 to 2a2a130 Compare March 5, 2025 02:04
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 5, 2025

@swift-ci smoke test

@gottesmm gottesmm force-pushed the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch from 2a2a130 to da37f7f Compare March 5, 2025 22:12
@gottesmm gottesmm force-pushed the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch from da37f7f to b0c3183 Compare March 5, 2025 22:13
@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 5, 2025

Needed to add SwiftSettings.cmake to the CMakeLists.txt file for the new runtime.

@gottesmm
Copy link
Contributor Author

gottesmm commented Mar 5, 2025

@swift-ci smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtimes build side of the change seems good.

@gottesmm gottesmm force-pushed the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch from b0c3183 to 900dcc8 Compare March 10, 2025 21:51
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge March 10, 2025 22:56
…tIsolation at the file level.

We introduce a new macro called #SwiftSettings that can be used in conjunction
with a new stdlib type called SwiftSetting to control the default isolation at
the file level. It overrides the current default isolation whether it is the
current nonisolated state or main actor (when -enable-experimental-feature
UnspecifiedMeansMainActorIsolated is set).
@gottesmm gottesmm force-pushed the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch from 900dcc8 to f64dd5a Compare March 11, 2025 00:33
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm merged commit 04bb69f into swiftlang:main Mar 11, 2025
3 checks passed
@gottesmm gottesmm deleted the pr-025c1133954b74e7b4eda77e1a6f3bcafd4eb6cf branch March 11, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants