[cxx-interop] Make experimental flag ImportNonPublicCxxMembers #79728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guards the functionality from 66c2e2c under a new experimental feature flag, ImportCxxNonPublicBaseMembers. Inheriting non-public base members triggers some latent ClangImporter bugs that we are not quite ready to iron out.
|
@swift-ci Please smoke test |
|
@swift-ci please smoke test |
|
Now, I'm thinking that perhaps I should actually make this flag |
|
@swift-ci please smoke test |
j-hui
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
fahadnayyar,
beccadax,
ian-twilightcoder,
hborla,
slavapestov,
xedin and
DougGregor
as code owners
Xazax-hun
approved these changes
Mar 3, 2025
|
Please update the title and the description with the new name/semantics. |
|
@swift-ci Please smoke test |
j-hui
changed the title
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClangImporter can now import non-public members as of be73254 and 66c2e2c, but doing so triggers some latent ClangImporter bugs in projects that don't use or need those non-public members.
This patch introduces a new experimental feature flag, ImportNonPublicCxxMembers, that guards against the importation of non-public members while we iron out those latent issues. Adopters of the SWIFT_PRIVATE_FILEID feature introduced in bdf2294 can enable this flag to opt into importing private members they wish to access from Swift.
rdar://145569473