test: Speed up test/Misc/verify-swift-feature-testing.test-sh some more
#79764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more Instead of first invoking `grep` to get a list of files with matches, and then invoking it again on each file to find lines with matches, invoke it once on the entire test suite to get a list of paths and lines with matches, and parse that output into a dictionary that maps file paths to lists of lines. This further reduces run time from ~2.5s to ~1s.
drodriguez
approved these changes
Mar 4, 2025
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of first invoking
grepto get a list of files with matches, and then invoking it again on each file to find lines with matches, invoke it once on the entire test suite to get a list of paths and lines with matches, and parse that output into a dictionary that maps file paths to lists of lines.This further reduces run time from ~2.5s to ~1s.