utils: cleanup module triple computation #79765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `swiftc` rather than `swift` as the latter is the driver driver driver. This simplifies the logic and should improve the computation path.
|
@swift-ci please smoke test |
andrurogerz
reviewed
Mar 4, 2025
| @@ -521,30 +521,21 @@ function Get-TargetInfo($Arch) { | |||
| # Cache the result of "swift -print-target-info" as $Arch.Cache.TargetInfo | |||
There was a problem hiding this comment.
If there is a failure, I'll update this, otherwise, I'll do that subsequently I think. I have a number of upcoming changes in the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
swiftcrather thanswiftas the latter is the driver driver driver. This simplifies the logic and should improve the computation path.