Skip to content

Fix Windows build as a result of recent GSB changes #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2017
Merged

Fix Windows build as a result of recent GSB changes #7977

merged 1 commit into from
Mar 8, 2017
+5 −6

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Mar 8, 2017

@hughbe
Copy link
Contributor Author

hughbe commented Mar 8, 2017

@swift-ci please smoke test and merge

@hughbe
Copy link
Contributor Author

hughbe commented Mar 8, 2017 •
edited
Loading

After some investigation, looks like an MSVC bug:
"MSVC can't compile nested class method with typedef-ed parameter referring to a typedef in a parent class"
https://connect.microsoft.com/VisualStudio/feedback/details/3127356

@swift-ci swift-ci merged commit e02de50 into swiftlang:master Mar 8, 2017
@DougGregor
Copy link
Member

Thanks @hughbe . Do we perhaps want to create a global typedef of WrittenRequirementLoc in GenericSignatureBuilder.cpp, rather than uglify each of the uses of it?

@hughbe hughbe deleted the gsb-msvc branch March 14, 2017 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughbe @DougGregor @swift-ci