Skip to content

[CoroutineAccessors] Dispatch and PtrAuth. #79781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 8, 2025

Conversation

nate-chandler
Copy link
Contributor

Put CFPs in vtables and wtables. Form full coroutine thunks in order to deallocate in the thunk continuation the frame for the destination coroutine allocated in the thunk rump function.

@nate-chandler nate-chandler force-pushed the general-coro/20250227/1 branch from 7865e3a to 46f61e9 Compare March 5, 2025 04:39
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-chandler nate-chandler force-pushed the general-coro/20250227/1 branch 3 times, most recently from 49e3d72 to 6acaa12 Compare March 6, 2025 18:39
@nate-chandler nate-chandler force-pushed the general-coro/20250227/1 branch 2 times, most recently from 72e63ce to 4cf2f64 Compare March 7, 2025 04:40
The implementation was deleted awhile back.
So it doesn't overflow on 32-bit targets.
Change the suffix to Twc and demangle.
This was useful during bringup.  Now that retcon.once.dynamic coroutine
splitting is available, it's no longer needed.
@nate-chandler nate-chandler force-pushed the general-coro/20250227/1 branch from 4cf2f64 to 6581fec Compare March 7, 2025 19:46
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler marked this pull request as ready for review March 8, 2025 04:08
@nate-chandler nate-chandler merged commit c0ba520 into swiftlang:main Mar 8, 2025
5 checks passed
@nate-chandler nate-chandler deleted the general-coro/20250227/1 branch March 8, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants