[cxx-interop] Use qualified name in import info of clang declarations #79791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susmonteiro
requested review from
zoecarver,
hyp,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar and
rjmccall
as code owners
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Mar 5, 2025
susmonteiro
force-pushed
the
susmonteiro/enums-same-gen-name
branch
from
1922c9b to
fb2522f
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/enums-same-gen-name
branch
from
fb2522f to
18ee0ee
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we had two enums with the same name in different namespaces/structs/classes, the import info name would be the same for both, resulting in a mix-up.
rdar://138485306