Add a flag to enable-new-runtime-build that enables the new runtime build #79804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
etcwilde
reviewed
Mar 5, 2025
There was a problem hiding this comment.
This change looks fine.
Can you replace the extra-cmake-optoins=-DSWIFT_ENABLE_NEW_RUNTIME_BUILD=YES in the build-presets.init with -enable-new-runtime-build here
Line 672 in 0997a7e
Thanks
…uild. What is nice about this is that by not using extra-cmake-args, we can avoid passing this into LLVM as well when attempting to reproduce failures on the bots (thus avoiding having to rebuild LLVM as well).
gottesmm
force-pushed
the
pr-f26aec536f9d333150b49e0faf50a70a9a26ac53
branch
from
f892bb3 to
7418b42
Compare
|
@swift-ci smoke test |
|
Linux is failing due to swift testing failing on WASI |
|
@swift-ci smoke test linux platform |
1 similar comment
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is nice about this is that by not using extra-cmake-args, we can avoid passing this into LLVM as well when attempting to reproduce failures on the bots (thus avoiding having to rebuild LLVM as well).