[Dependency Scanning] Unique collected cross-import overlay files with a set #79809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h a set Resolves rdar://146141228
artemcm
requested review from
cachemeifyoucan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
cachemeifyoucan
approved these changes
Mar 5, 2025
| @@ -254,7 +254,7 @@ ModuleDependencyInfo::collectCrossImportOverlayNames( | |||
| ModuleDecl::collectCrossImportOverlay(ctx, file, moduleName, | |||
| bystandingModule); | |||
| result[bystandingModule] = std::move(overlayNames); | |||
| overlayFiles.push_back({moduleName.str(), file.str()}); | |||
| overlayFiles.insert({moduleName.str(), file.str()}); | |||
There was a problem hiding this comment.
collectCrossImportOverlay is not exactly cheap. Can we skip if we know the entry is in the set already?
|
@swift-ci smoke test Linux platform |
3 similar comments
|
@swift-ci smoke test Linux platform |
|
@swift-ci smoke test Linux platform |
|
@swift-ci smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://146141228