[sil] Add missing flag to SILDeclRef's hash and change SILDeclRef to use llvm::hash_combine instead of rolling its own hash combiner. #79825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use llvm::hash_combine instead of rolling its own hash combiner. This is really old code from before llvm::hash_combine existed. We really shouldn't be rolling out own hash combine when we have something that we are consistently using from LLVM. I validated the history of this code and talked with JoeG/DougG/others to see if there was any reason beyond not having hash_combine for us not to use hash_combine. The reason why I am changing this now is that I want to convert SILDeclRef to have another additional bit and use an OptionSet. When I noticed this... my eyes burned, so I thought I would just quickly fix it before I landed the other change so it could be a NFC change.
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really old code from before llvm::hash_combine existed. We really shouldn't be rolling out own hash combine when we have something that we are consistently using from LLVM. I validated the history of this code and talked with JoeG/DougG/others to see if there was any reason beyond not having hash_combine for us not to use hash_combine.
The reason why I am changing this now is that I want to convert SILDeclRef to have another additional bit and use an OptionSet. When I noticed this... my eyes burned, so I thought I would just quickly fix it before I landed the other change so it could be a NFC change.