Skip to content

utils: Consistent spelling of $Env in build.ps1. #79832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2025
Merged

utils: Consistent spelling of $Env in build.ps1. #79832

merged 1 commit into from
Mar 8, 2025

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Mar 7, 2025

Currently we $env and $Env are both used. Let's just pick one.

compnerd
compnerd approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure; is Env the PS recommendation or is env?

@jeffdav
Copy link
Contributor Author

jeffdav commented Mar 7, 2025

I don't think there is an official recommendation. They use both cases in the documentation.

I went with $Env because all the other variables are (or should be) PascalCased. But I'm also fine to make them all $env if we like that better for some reason.

@compnerd
Copy link
Member

compnerd commented Mar 7, 2025

I think that env:* looks nicer 🤷‍♂️ I'm generally a fan of PascalCase for conjugate words.

@jeffdav
Copy link
Contributor Author

jeffdav commented Mar 7, 2025

That's fewer changes anyway. ✅

@compnerd
Copy link
Member

compnerd commented Mar 8, 2025

@swift-ci please smoke test

@compnerd compnerd enabled auto-merge March 8, 2025 07:07
@compnerd compnerd merged commit 6acf631 into swiftlang:main Mar 8, 2025
3 checks passed
@jeffdav jeffdav deleted the win-build-env branch March 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdav @compnerd