Fix two optimizer issues #79841
Merged
Fix two optimizer issues #79841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
requested review from
atrick,
eeckstein and
nate-chandler
and removed request for
eeckstein
|
@swift-ci test |
meg-gupta
changed the title
Copy propagation does these optimizations more generally. It should be able to replace this optimization. Fixing it and not just deleting CopyValueOpts because it happens to be called in the mandatory pipeline.
Otherwise, DestroyHoisting attemps to compute interior liveness and inserts destoys at the ends. CanonicalizeOSSALifetimes is designed to do this and not DestroyHoisting.
meg-gupta
force-pushed
the
fixsemanticarc
branch
from
c7f18bd to
cd684a3
Compare
|
@swift-ci test |
eeckstein
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://146142041