[Parse/AST] Remove PoundDiagnosticDecl #79857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
hamishknight,
xymus,
slavapestov,
hborla,
xedin,
jckarter,
CodaFi,
DougGregor,
rjmccall,
tshortli and
eeckstein
as code owners
|
@swift-ci Please smoke test |
There is no reson to make a AST node for '#error' and '#warning' directives. Parser knows the diagnostics should be emitted or not.
rintaro
force-pushed
the
retire-pound-diagnostics-decl
branch
from
0ccf414 to
7dd6d0b
Compare
|
@swift-ci Please smoke test |
DougGregor
approved these changes
Mar 8, 2025
|
swiftlang/llvm-project#10211 |
Now that there is no way SwitchStmt to hold AST nodes other than CaseStmt.
rintaro
force-pushed
the
retire-pound-diagnostics-decl
branch
from
7dd6d0b to
5eac58e
Compare
|
swiftlang/llvm-project#10211 |
1 similar comment
|
swiftlang/llvm-project#10211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to make a AST node for '#error' and '#warning' directives. Parser knows the diagnostics should be emitted or not.
After removing
PoundDiagnosticDecl, makeSwitchStmtonly holdCaseStmt.