Sema: Optimize Constraint layout to save 24 bytes #79882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplementation Normal conformances, self conformances, and availability contexts cannot contain types with type variables, so there is no reason to duplicate the uniquing maps between the permanent arena and solver arena.
The largest union member was for SyntacticElement constraints; let's tail-allocate the ContextualTypeInfo instead of storing one in every constraint.
slavapestov
force-pushed
the
sizeof-constraint
branch
from
f92f28d to
a7a19a0
Compare
slavapestov
changed the title
slavapestov
force-pushed
the
sizeof-constraint
branch
from
b2a5fbd to
83118a7
Compare
If the precondition doesn't hold, we will return a pointer to some random memory, so it's best to always crash since this indicates something is seriously wrong.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
AnthonyLatsis
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building the standard library, the total size of all constraint solver arenas allocated goes down from 638Mb to 596Mb.
Fixes rdar://146459456