[ownership-value] When passing in a class to materializeForSet, use astore_borrow, rather than a store [init]. #7990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… store_borrow, rather than a store [init]. The reason why this needs to be done is that we represent class pointers as guaranteed, but we need to pass them as inout, violating the guaranteed assumption. The truth is, we should be passing them in guaranteed but due to the large required AST changes needed, we do not today. Since we model this as an inout today, SILGen rightfully tries to use a store [init] which is consuming. This commit works around that issue by using a store_guaranteed. rdar://29791263
|
@swift-ci Please smoke test and merge |
gottesmm
deleted the
use_store_borrow_instead_store_init_for_class_vars_mutableForSet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ownership-value] When passing in a class to materializeForSet, use astore_borrow, rather than a store [init].
The reason why this needs to be done is that we represent class pointers as
guaranteed, but we need to pass them as inout, violating the guaranteed
assumption. The truth is, we should be passing them in guaranteed but due to the
large required AST changes needed, we do not today.
Since we model this as an inout today, SILGen rightfully tries to use a store
[init] which is consuming. This commit works around that issue by using a
store_guaranteed.
rdar://29791263