Sema: Adjust result builder operation lookup for MemberImportVisibility #79902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
xedin
approved these changes
Mar 11, 2025
To avoid spurious diagnostics about unavailable operations when checking uses of functions that take result builder closures, lookup of result builder operations needs to ignore the restrictions of the `MemberImportVisibility` feature. The result builder transform should simply use the operations that are found and allow later checks to diagnose the use of inaccessible builder operations. Resolves rdar://144100445.
tshortli
force-pushed
the
result-builder-member-import-visibility
branch
from
4c94849 to
7a514c9
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid spurious diagnostics about unavailable operations when checking uses of functions that take result builder closures, lookup of result builder operations needs to ignore the restrictions of the
MemberImportVisibilityfeature. The result builder transform should simply use the operations that are found and allow later checks to diagnose the use of inaccessible builder operations.Resolves rdar://144100445.