[cxx-interop] Do not require the LifetimeDependence feature in _SwiftifyImport #79911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla,
slavapestov and
xedin
as code owners
Xazax-hun
force-pushed
the
gaborh/enable-lifetime-in-macro-generated
branch
from
4d04421 to
ff8ad7e
Compare
…ifyImport We use experimental features to let people know that the construct is subject to change and users should not rely on this unless they are willing to rewrite the uses of this feature later. However, in compiler generated code everything should be fair game, we will update the compiler when these features change. This is a requirement to be able to turn safe wrapper generation on by default.
Xazax-hun
force-pushed
the
gaborh/enable-lifetime-in-macro-generated
branch
from
ff8ad7e to
22e2276
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use experimental features to let people know that the construct is subject to change and users should not rely on this unless they are willing to rewrite the uses of this feature later. However, in compiler generated code everything should be fair game, we will update the compiler when these features change. This is a requirement to be able to turn safe wrapper generation on by default.