AST: rename OpenArchetypeType -> ExistentialArchetypeType #79917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
xymus,
AnthonyLatsis,
hborla,
slavapestov,
xedin,
ktoso,
jckarter,
adrian-prantl,
rjmccall,
ahoppen,
bnbarham,
hamishknight,
rintaro and
tshortli
as code owners
|
@swift-ci test |
|
Thanks! |
slavapestov
approved these changes
Mar 11, 2025
| @@ -759,7 +759,7 @@ \section{Source Code Reference}\label{typesourceref} | |||
| \item \texttt{ArchetypeType}, and its three subclasses: | |||
| \begin{itemize} | |||
| \item \texttt{PrimaryArchetypeType}, | |||
| \item \texttt{OpenedArchetypeType}, | |||
| \item \texttt{ExistentialArchetypeType}, | |||
There was a problem hiding this comment.
You didn’t have to update this, but thanks! There’s a whole unfinished chapter on existential types I’ll get around to finishing some day…
| @@ -114,6 +114,9 @@ enum class TypeKind : uint8_t { | |||
| #define TYPE_RANGE(Id, FirstId, LastId) \ | |||
| First_##Id##Type = FirstId, Last_##Id##Type = LastId, | |||
| #include "swift/AST/TypeNodes.def" | |||
| // For backward compatibility in LLDB sources. | |||
| // TODO: remove this once OpenedArchetype is renamed in LLDB sources. | |||
| OpenedArchetype = ExistentialArchetype | |||
There was a problem hiding this comment.
You could also update lldb at the same time and do a cross-repo test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFC
Suggested by @slavapestov