SIL: Fix recent bug introduced into old style mangling of specializations #7993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions The format is "type conformances... '_'" for each substitutable generic parameter. I broke it so that it emits types for the substitutable parameters but conformances for all requirements in the signature. This changed the mangling of specializations where the function being specialized placed additional constraints on associated types, causing demangling failure in the pre-specialization whitelist code. This might fix <rdar://problem/30932656>.
|
No test because the old mangling is going away, and new mangling has its own issues (it doesn't mangle conformances in substitutions, which is wrong for property behaviors and private conformances). |
|
@swift-ci Please smoke test |
|
@swiftix Please review |
|
@slavapestov Looks good! I checked locally that it fixes the performance regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format is "type conformances... '_'" for each substitutable
generic parameter. I broke it so that it emits types for the
substitutable parameters but conformances for all requirements
in the signature.
This changed the mangling of specializations where the function
being specialized placed additional constraints on associated
types, causing demangling failure in the pre-specialization
whitelist code.
This might fix rdar://problem/30932656.