Skip to content

Fix call to templated readFullContextDescriptor method #79936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

j-hui
Copy link
Contributor

@j-hui j-hui commented Mar 12, 2025

This function call was causing an error in my local builds:

In file included from /Users/j-hui/Documents/open2/swift/stdlib/public/RemoteInspection/TypeLowering.cpp:27:
In file included from /Users/j-hui/Documents/open2/swift/include/swift/RemoteInspection/TypeLowering.h:24:
/Users/j-hui/Documents/open2/swift/include/swift/Remote/MetadataReader.h:1524:21: error: use 'template' keyword to treat 'readObj' as a dependent template name
 1524 |       ptr = Reader->readObj<DescriptorTy>(address);
      |                     ^
      |                     template
1 error generated.

Applying the suggested fix seemed to resolve the issue.

@j-hui
Copy link
Contributor Author

j-hui commented Mar 12, 2025

@swift-ci please smoke test

@j-hui j-hui marked this pull request as ready for review March 12, 2025 17:26
@j-hui j-hui requested a review from mikeash March 12, 2025 17:26
@j-hui j-hui merged commit 42ad91e into main Mar 12, 2025
3 checks passed
@j-hui j-hui deleted the j-hui/fix-readFullContextDescriptor branch March 12, 2025 17:29
j-hui added a commit to j-hui/swift that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants