Skip to content

Support for copy-on-write existentials - IRGen Support #8005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 10, 2017
Merged

Support for copy-on-write existentials - IRGen Support #8005

merged 9 commits into from
Mar 10, 2017

Conversation

aschwaighofer
Copy link
Contributor

This adds non-witness implementation of copy-on-write opaque existentials to IRGen.

Missing is the runtime support.

All this is hidden behind the CMake flag 'SWIFT_RUNTIME_ENABLE_COW_EXISTENTIALS' and the compiler frontend flag '-enable-cow-existentials'.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please clean test

@dabrahams
Copy link
Contributor

🎉

@swift-ci
Copy link
Contributor

swift-ci commented Mar 9, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2592a6afe0db300292a6be1f1b322f90f33c2170
Test requested by - @aschwaighofer

@aschwaighofer aschwaighofer force-pushed the cow_existential_wip_04 branch from 2592a6a to 36ae499 Compare March 9, 2017 22:29
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

swift-ci commented Mar 9, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2592a6afe0db300292a6be1f1b322f90f33c2170
Test requested by - @aschwaighofer

@swift-ci
Copy link
Contributor

swift-ci commented Mar 9, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 2592a6afe0db300292a6be1f1b322f90f33c2170
Test requested by - @aschwaighofer

@aschwaighofer
Add an option to enable a copy-on-write existential implementation
0258926
@aschwaighofer
SILGen: Disable moving out of opened existential values in copy-on-wr…
fc88159 
…ite mode
@aschwaighofer
Move getArgumentConvention from FullApplySite to ApplySite.
6218482
@aschwaighofer
SIL: Add verification of open_existential_addr instructions
1c9f7f5 
Make sure that all uses of "immutable_access" instructions are not mutating the
opened value.

Only enable verification if we have COW existentials enabled.
@aschwaighofer
Add a function to allocate a box for out-line existential value buffer
5210258
@aschwaighofer
Non-witness implementations of init_existential_addr, deinit_existent…
80732ea 
…ial_addr, open_existential_addr, copy_addr, destory_addr

For the boxed existential variant.
@aschwaighofer
Add an option to build the runtime with copy-on-write existentials
d42c806
@aschwaighofer
Pass down the SWIFT_RUNTIME_ENABLE_COW_EXISTENTIALS flag to the runti…
49b3377 
…me build.
@aschwaighofer
SILVerifier: Fix the opened c-o-w existential check for debug_value_a…
85b126d 
…ddr instruction
@aschwaighofer aschwaighofer force-pushed the cow_existential_wip_04 branch from 36ae499 to 85b126d Compare March 10, 2017 01:22
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 36ae49925c1a767b4f419405d224191be852fc4d
Test requested by - @aschwaighofer

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 36ae49925c1a767b4f419405d224191be852fc4d
Test requested by - @aschwaighofer

@aschwaighofer aschwaighofer merged commit dc16a94 into swiftlang:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschwaighofer @dabrahams @swift-ci