AST: Introduce DeclRuntimeAvailability
#80051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
jckarter,
hborla,
slavapestov and
xedin
as code owners
It can be replaced by querying the `AvailabilityContext` for a declaration directly.
Extract the tests that verify back deployment of the standard library function `diagnoseUnavailableCodeReached()` into a separate, multi-platform test.
tshortli
force-pushed
the
refactor-semantic-decl-availability-request
branch
from
9b64a34 to
24eb380
Compare
tshortli
requested review from
AnthonyLatsis,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Generalize the implementation of `SemanticDeclAvailabilityRequest` in preparation for adding a new case to `SemanticDeclAvailability`. Use the centralized availability constraint query instead of implementing a bespoke algorithm for gathering constraints. Simplify `SemanticDeclAvailability` by removing a case that is no longer relevant. Part of rdar://138441307.
tshortli
force-pushed
the
refactor-semantic-decl-availability-request
branch
from
24eb380 to
7ed2a0d
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclRuntimeAvailabilityRequestis a replacement forSemanticDeclAvailabilityRequestand satisfies a narrower query that only determines whether a decl is reachable by execution at runtime (rather than whether it is also considered available at compile time).DeclRuntimeAvailabilityRequestleverages the availability constraint machinery to determine whether a decl is available at runtime, rather than re-implementing it.