Disable building Ninja tests #80093
Merged
Disable building Ninja tests #80093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninja builds its tests by default. We don't run the Ninja test suite, we aren't doing development on Ninja, and we are using a release tag that has been verified to work. There isn't much point in building the tests if we're not going to use them. Disabling building the Ninja tests. If it is desirable to build them, one can set `BUILD_TESTING` to `YES` and re-run their build.
|
@swift-ci please smoke test |
compnerd
approved these changes
Mar 18, 2025
edymtt
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ninja builds its tests by default.
We don't run the Ninja test suite, we aren't doing development on Ninja, and we are using a release tag that has been verified to work. There isn't much point in building the tests if we're not going to use them. Disabling building the Ninja tests. If it is desirable to build them, one can set
BUILD_TESTINGtoYESand re-run their build.