[build-script]: Automatically choose a built ninja #80102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
edymtt
approved these changes
Mar 18, 2025
utils/swift_build_support/swift_build_support/products/ninja.py
Outdated
Show resolved
Hide resolved
compnerd
approved these changes
Mar 18, 2025
etcwilde
force-pushed
the
ewilde/choose-built-ninja
branch
2 times, most recently
from
bd426d7 to
7db7b3d
Compare
|
@swift-ci please test |
Instead of using `--build-ninja` to decide to build ninja, build it automatically if a sufficiently new enough version is not available. Also record the build time taken to build the local Ninja so that we can see how much time we would save by stashing a pre-built Ninja in CI.
etcwilde
force-pushed
the
ewilde/choose-built-ninja
branch
from
7db7b3d to
9402a16
Compare
|
@swift-ci please test |
drodriguez
added a commit
that referenced
this pull request
Mar 21, 2025
The test was using the default value for SWIFT_BUILD_ROOT, which tried to write into `.build_script_log`. Use an environment variable so the tests use their own directory and write files that do not append to the actual `.build_script_log`. Follow up to #80102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
--build-ninjato decide to build ninja, build it automatically if a sufficiently new enough version is not available. Also record the build time taken to build the local Ninja so that we can see how much time we would save by stashing a pre-built Ninja in CI.This is more like how build-script pre-builds CMake when necessary.