[CMake] Refactor resync script individual file copying #80106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting the file copying out of the library copying. This allows us to list a specific set of files to copy into the new stdlib build from specific locations.
Use the new copy_files to copy specific files into the appropriate places without needing to duplicate as much code.
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the individual file copies that were sitting around. I've split the logic for copying each file from
copy_library_sourcesinto a separatecopy_filesfunction. That function takes afrom_prefix,to_prefix, an optionalROOTdirectory for sources that won't be coming from the standard library source directory (StringProcessing), and a list of files. This helps keep related files grouped together more clearly, like the Windows clang module maps, for instance.