Serialization: Protect deserializeEnum and more against failures
#80108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
Rename the macro UNWRAP to SET_OR_RETURN_ERROR for clarity and invert its parameters to have a more intuitive order of assignment target and then expression.
Recover from a raw type hidden behind an internal or implementation-only import by dropping the whole enum when the raw type is unavailable. This scenario should happen only when looking at non-public decl for indexing or debugging, or if dependencies somehow changed and left behind a stale swiftmodule file. rdar://147091863
xymus
force-pushed
the
deser-protect-enum-raw-type
branch
from
b6733fe to
0ac3f04
Compare
|
@swift-ci Please smoke test |
xymus
force-pushed
the
deser-protect-enum-raw-type
branch
from
0ac3f04 to
4615615
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover from a raw type hidden behind an
internalor implementation-only import by dropping the whole enum when the raw type is not visible. This scenario should happen only when looking at non-public decl for indexing or debugging, or if dependencies somehow changed and left behind a stale swiftmodule file.Apply the same recovery logic to other notable uses of
getTypeat deserializing a class or parameter.Also clean up a few related pieces of code. Rename the macro
UNWRAPtoSET_OR_RETURN_ERRORfor clarity and invert its parameters to have a more intuitive order of assignment target and then expression. And update the multipurpose testimplementation-only-missing.swiftto use split-file.rdar://147091863