[CMake] Use CXX linker for Core and Concurrency #80139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
compnerd
requested changes
Mar 19, 2025
etcwilde
force-pushed
the
ewilde/use-clangxx-linker
branch
from
add47be to
0f3fe94
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Mar 20, 2025
|
@swift-ci please smoke test Linux |
etcwilde
force-pushed
the
ewilde/use-clangxx-linker
branch
from
0f3fe94 to
333f26a
Compare
compnerd
approved these changes
Mar 24, 2025
swiftCore and swift_Concurrency libraries use C++ and Swift. The C++ does not use the Swift C++ interop. Swift driver only uses clang++ to link when building in C++ interop mode and there currently isn't a flag to change that. Since we're explicitly linking the runtime registration when necessary and do not need compatibility libraries, it is safe to use clang++ as the linker directly, instead of going through swiftc. In versions of CMake older than 3.29, Swift is always used as a linker and has no compile stage. By using clang++ as the linker, we require the split build model (CMP0157), so we cannot allow versions of CMake older than 3.29.
etcwilde
force-pushed
the
ewilde/use-clangxx-linker
branch
from
333f26a to
1dc97c2
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftCore and swift_Concurrency libraries use C++ and Swift. The C++
does not use the Swift C++ interop. Swift driver only uses clang++ to
link when building in C++ interop mode and there currently isn't a flag
to change that. Since we're explicitly linking the runtime registration
when necessary and do not need compatibility libraries, it is safe to
use clang++ as the linker directly, instead of going through swiftc.
In versions of CMake older than 3.29, Swift is always used as a linker
and has no compile stage. By using clang++ as the linker, we require the
split build model (CMP0157), so we cannot allow versions of CMake older
than 3.29.