Update ucrt.modulemap for Windows SDK 10.0.26100 #80144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick from pull request swiftlang#79751
compnerd
approved these changes
Mar 20, 2025
|
@swift-ci please smoke test |
|
For future reference, this is the failure: |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
2 similar comments
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci test macOS |
|
@swift-ci test Linux |
shahmishal
approved these changes
Mar 25, 2025
DivineDominion
added a commit
to DivineDominion/swift-cross-ui
that referenced
this pull request
May 10, 2025
There are now fixes to compnerd/swift-build#909 and swiftlang/swift#79751, swiftlang/swift#80144 is merged.
stackotter
pushed a commit
to stackotter/swift-cross-ui
that referenced
this pull request
May 10, 2025
* enable swift build since swiftlang/swift-package-manager#6644 is fixed * update compnerd/gha-setup-swift to v0.3.0 * use latest Windows and Swift 6.1 There are now fixes to compnerd/swift-build#909 and swiftlang/swift#79751, swiftlang/swift#80144 is merged. * enable building WinUIBackend * specify which target to build to avoid missing Gtk
award999
added a commit
to award999/vscode-swift
that referenced
this pull request
May 21, 2025
Hasn't been a build off release/6.1 since March 3rd but we need the fix for swiftlang/swift#80144 that was made March 25th
award999
added a commit
to swiftlang/vscode-swift
that referenced
this pull request
May 21, 2025
* Disable nightly-6.1 run for Windows Hasn't been a build off release/6.1 since March 3rd but we need the fix for swiftlang/swift#80144 that was made March 25th * Fix lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows SDK 10.0.26100 added an include to compiler intrinsics headers in
wchar.h. In turn, these headers includemalloc.h,stdlib.handstddef.hfromucrt, this leads to a cyclic dependency between theucrtand compiler intrinsics modules. Furthermore, Clang 19 (from Swift 6.1) intrinsics headers sometimes clash with the ucrt headers dependencies.These changes separate the problematic headers into different standalone modules.
The changes are limited to
ucrt.modulemap, and should be backward-compatible with older Windows SDK versions.Update ucrt.modulemap for Windows SDK 10.0.26100 #79751
Restore legacy_stdio_definitions in ucrt.modulemap #80151
Put float and stddef back inside the ucrt module #80200
Very low.
Local testing with simple projects including the
ucrtmodule with the new module map.@compnerd