Skip to content

Restore legacy_stdio_definitions in ucrt.modulemap #80151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions stdlib/public/Platform/ucrt.modulemap
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ module ucrt [system] {
module stdio {
header "stdio.h"
export *

// NOTE(compnerd) this is a horrible workaround for the fact that
// Microsoft has fully inlined nearly all of the printf family of
// functions in the headers which results in the definitions being elided
// resulting in undefined symbols. The legacy_stdio_definitions provides
// out-of-line definitions for these functions.
link "legacy_stdio_definitions"
}

module stdlib {
Expand Down