Skip to content

[Concurrency] Change signposts to use decimal format for task ids #80154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Mar 20, 2025

Change task ids to be formatted using decimal instead of hex.

An example of previous signposts:

task=e resumefn=0x2807722bc jobPriority=0 isChildTask=0, isFuture=1 isGroupChildTask=0 isAsyncLetTask=0 parent=0 group=0x0 asyncLet=0x0

this will now show task=14 instead of task=e

@kastiglione kastiglione requested a review from ktoso as a code owner March 20, 2025 00:02
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm! Yeah decimal is much nicer for those

@ktoso
Copy link
Contributor

ktoso commented Mar 20, 2025

@swift-ci please smoke test

@kastiglione
Copy link
Contributor Author

@swift-ci smoke test windows

@kastiglione
Copy link
Contributor Author

Before merging, I am coordinating to see if this will impact any consumers of these signposts.

@kastiglione
Copy link
Contributor Author

This commit won't break the folks I checked with.

@kastiglione kastiglione merged commit 6ca8e0d into main Mar 20, 2025
3 checks passed
@kastiglione kastiglione deleted the dl/Concurrency-Change-signposts-to-use-decimal-format-for-task-ids branch March 20, 2025 20:23
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Mar 21, 2025
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Mar 21, 2025
kastiglione added a commit to swiftlang/llvm-project that referenced this pull request Mar 21, 2025
kastiglione added a commit that referenced this pull request Mar 27, 2025
Use decimal to display Task IDs. This matches changes being done else where to use decimal consistently for Task IDs. For example #80154 and swiftlang/llvm-project#10308.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants