-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Concurrency] Change signposts to use decimal format for task ids #80154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kastiglione
merged 1 commit into
main
from
dl/Concurrency-Change-signposts-to-use-decimal-format-for-task-ids
Mar 20, 2025
Merged
[Concurrency] Change signposts to use decimal format for task ids #80154
kastiglione
merged 1 commit into
main
from
dl/Concurrency-Change-signposts-to-use-decimal-format-for-task-ids
Mar 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lgtm! Yeah decimal is much nicer for those
@swift-ci please smoke test |
@swift-ci smoke test windows |
Before merging, I am coordinating to see if this will impact any consumers of these signposts. |
This commit won't break the folks I checked with. |
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 21, 2025
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 21, 2025
See also swiftlang/swift#80154 (cherry-picked from commit c29ca84)
kastiglione
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Mar 21, 2025
See also swiftlang/swift#80154 (cherry-picked from commit c29ca84)
kastiglione
added a commit
that referenced
this pull request
Mar 27, 2025
Use decimal to display Task IDs. This matches changes being done else where to use decimal consistently for Task IDs. For example #80154 and swiftlang/llvm-project#10308.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change task ids to be formatted using decimal instead of hex.
An example of previous signposts:
this will now show
task=14
instead oftask=e