Fix .swiftdeps file deterministic issues
#80172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
artemcm
approved these changes
Mar 20, 2025
cachemeifyoucan
force-pushed
the
eng/PR-147513165
branch
from
0f67a7c to
7acebf2
Compare
|
Yikes, the |
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-147513165
branch
from
7acebf2 to
314e6e3
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@DougGregor to make sure my updated |
Make sure the traversal order for classMembers in deterministic in the mdoule by sorting them first. Also fix the comparsion function for `DeclName` to make sure there aren't two DeclNames with different OpaquePointer can be evaluated to equal. rdar://147513165
Use a null diagnostic consumer in the deterministic verify instance. The constraint system will skip work if there are no consumer in the diagnostic engine. Use a null consumer to make sure the same amount of work is done for two runs.
cachemeifyoucan
force-pushed
the
eng/PR-147513165
branch
from
314e6e3 to
4115be5
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two more deterministic issue for swiftdeps output: