Change the backing base name type of DeclName to DeclBaseName #8019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Mar 10, 2017
include/swift/AST/Identifier.h
Outdated
| static inline swift::DeclBaseName getFromVoidPointer(void *P) { | ||
| return swift::Identifier::getFromOpaquePointer(P); | ||
| } | ||
| enum { NumLowBitsAvailable = 2 }; |
There was a problem hiding this comment.
This should probably be PointerLikeTypeTraits<swift::Identifier>::NumLowBitsAvailable.
include/swift/AST/Identifier.h
Outdated
| return const_cast<void *>(D.getAsOpaquePointer()); | ||
| } | ||
| static inline swift::DeclBaseName getFromVoidPointer(void *P) { | ||
| return swift::Identifier::getFromOpaquePointer(P); |
There was a problem hiding this comment.
It's a bit weird that these two aren't symmetrical.
There was a problem hiding this comment.
Whoops, the second one was meant to be swift::DeclBaseName::getFromOpaquePointer(P)
The new DeclBaseName type will later be able to hold either normal identifiers (as they exist now) or special names that don't have an identifier (like subscripts)
ahoppen
force-pushed
the
backing-type-of-DeclName
branch
from
6cbb8ec to
4f0ab96
Compare
|
@swift-ci please test |
|
Build failed |
jrose-apple
approved these changes
Mar 11, 2017
|
Let's try Linux again @swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new DeclBaseName type will later be able to hold either normal identifiers (as they exist now) or special names that don't have an identifier (like subscripts)
The
TODOin this PR will be addressed in PRs for subsequent commits of #6848.