[concurrency] Make sure that TypeLowering inserts the extra actor parameter for @execution(caller) parameters. #80210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Type. Otherwise, it gets confusing when debugging in the debugger since dumpPrint will print out the function type isolation, but dump will not.
…ameter for @execution(caller) parameters. Previously, we handled cases where we had an actual SILDeclRef constant (e.x.: an actual function ref), but we did not handle cases where we did not have a constant but instead just had a FunctionTypeIsolation. We now handle that correctly.
gottesmm
requested review from
jckarter,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
|
@swift-ci smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[concurrency] Make sure that TypeLowering inserts the extra actor parameter for @execution(caller) parameters.
Previously, we handled cases where we had an actual SILDeclRef constant (e.x.:
an actual function ref), but we did not handle cases where we did not have a
constant but instead just had a FunctionTypeIsolation. We now handle that
correctly.