LifetimeDependence: enable addressable dependencies #80223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
force-pushed
the
enable-addressable
branch
2 times, most recently
from
cff4af4 to
d94a4dc
Compare
Preserve conditionallyAddressableParamIndices independent of any addressableParamIndices. The conditional dependencies are subject to change based on type substitution.
With this approach, you cannot tell whether a parameter is addressable only from the function type. Instead you need the SILValue that will be passed to the call site.
atrick
force-pushed
the
enable-addressable
branch
from
d94a4dc to
be2c6ee
Compare
atrick
requested review from
eeckstein,
jckarter,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
atrick
force-pushed
the
enable-addressable
branch
from
be2c6ee to
69cfe61
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable addressable dependencies
Handle conditionallyAddressableParamIndices. Preserve conditionallyAddressableParamIndices independent of any addressableParamIndices. The conditional dependencies are subject to change based on type substitution.