Skip to content

Fix a compilation error with LLVM 21 #80238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

alexfh
Copy link
Contributor

@alexfh alexfh commented Mar 24, 2025

This fixes a copy constructor must pass its first argument by reference compilation error when compiled with a recent enough Clang (after llvm/llvm-project@fe0d3e3, targeted for LLVM 21 release).

swift/stdlib/public/runtime/GenericMetadataBuilder.cpp:59:31: error: copy constructor must pass its first argument by reference
   59 |     Buffer(Buffer<const char> buffer)
      |                               ^
      |                               const &

This fixes a `copy constructor must pass its first argument by reference` compilation error when compiled with a recent enough Clang (after llvm/llvm-project@fe0d3e3)
@alexfh alexfh requested review from mikeash and al45tair as code owners March 24, 2025 10:48
@alexfh
Copy link
Contributor Author

alexfh commented Mar 24, 2025

@swift-ci

@allevato
Copy link
Member

@swift-ci please test

Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@allevato allevato enabled auto-merge March 24, 2025 11:39
@allevato allevato merged commit 815c3e8 into swiftlang:main Mar 24, 2025
4 of 5 checks passed
@alexfh alexfh deleted the patch-1 branch March 24, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants