Disable CompatibilitySpans outside of stdlib build #80282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slavapestov PTAL, I believe #79703 introduced the problem. We hit this issue when building early build tools. |
In some cases, like when building the Swift toolchain build tools, `SWIFT_STDLIB_LIBRARY_BUILD_TYPES` is not defined. This causes a configuration failure when the `CompatibilitySpan` library is being added. This commit sets a default value of `STATIC` to work around this problem.
Steelskin
force-pushed
the
fabrice/define-swift-stdlib-build-types-missing
branch
from
0c93ff1 to
9505d55
Compare
|
You can change it to not build the library at all in this case. It’s only needed for dynamic linking on Apple platforms. |
Steelskin
changed the title
Thank you. Is this what you had in mind? |
slavapestov
approved these changes
Mar 25, 2025
|
@swift-ci Please smoke test |
|
Could you re-run it please? It looks like the build hit a compiler crash. |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, like when building the Swift toolchain build tools,
SWIFT_STDLIB_LIBRARY_BUILD_TYPESis not defined. This causes a configuration failure when theCompatibilitySpanlibrary is being added.This commit disables the
CompatibilitySpantarget whenSWIFT_STDLIB_LIBRARY_BUILD_TYPESis not set.