[LLDB] Turn off resilience bypass for textual swiftinterface files #80283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the old comment indicates, it was not expected that build systems would register binary swift modules produced from textual interfaces with -add_ast_path, but we have found examples of the in the wild and it leads to the most unexpected side effects. Fixing this is straightforward, we can just check if a binary module was compiled from a textual interface and then not bypass resilience. rdar://145226754
|
I'm still working on a test for this in the LLDB testsuite. |
|
@swift-ci test |
|
Test in swiftlang/llvm-project#10347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the old comment indicates, it was not expected that build systems would register binary swift modules produced from textual interfaces with -add_ast_path, but we have found examples of the in the wild and it leads to the most unexpected side effects. Fixing this is straightforward, we can just check if a binary module was compiled from a textual interface and then not bypass resilience.
rdar://145226754